[
https://issues.apache.org/jira/browse/THRIFT-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959674#comment-15959674
]
ASF GitHub Bot commented on THRIFT-4172:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1244
THRIFT-4172: fix node.js tutorial when connection fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1244
----
commit d54ca8579401bcf1741872a5b4e65278f60ad0ac
Author: James E. King, III <[email protected]>
Date: 2017-04-06T20:19:04Z
THRIFT-4172: fix node.js tutorial when connection fails
----
> node.js tutorial client does not import assert, connection issues are not
> handled properly
> ------------------------------------------------------------------------------------------
>
> Key: THRIFT-4172
> URL: https://issues.apache.org/jira/browse/THRIFT-4172
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> Opening a Jira ticket for https://github.com/apache/thrift/pull/1037 and
> resubmitting to kick a CI build for it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
