[
https://issues.apache.org/jira/browse/THRIFT-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961001#comment-15961001
]
ASF GitHub Bot commented on THRIFT-4099:
----------------------------------------
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1246
@jeking3 I did, though unfortunately the communication was all on [the
original Rust Thrift](https://issues.apache.org/jira/browse/THRIFT-2945). I
suggested that Tony - the submitter - split up his changes into separate PRs to
simplify review and testing. I also created [individual
JIRAs](https://issues.apache.org/jira/browse/THRIFT-2945?focusedCommentId=15878212&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15878212)
for each of the pieces we agreed to. Unfortunately it looks like he went AWOL
after that :/
I'm now attacking those PRs one by one.
> Auto-derive Hash for generated Rust structs
> -------------------------------------------
>
> Key: THRIFT-4099
> URL: https://issues.apache.org/jira/browse/THRIFT-4099
> Project: Thrift
> Issue Type: Improvement
> Components: Rust - Compiler
> Reporter: Allen George
> Assignee: James E. King, III
> Priority: Minor
> Fix For: 0.11.0
>
>
> Currently Thrift structs are turned into Rust {{struct}} definitions that do
> not have an auto-derived {{Hash}}. We should auto-derive this trait.
> The following behaviors should be checked:
> # Can still derive {{Hash}} even if the struct contains a {{double}}
> # Can still derive {{Hash}} even if the struct contains {{set<double>}}
> # Can still derive {{Hash}} even if the struct contains {{map<double,
> double>}}
> Basically, doubles are represented in the auto-generated code by
> {{OrderedFloat}} instead of {{f64}} since we cannot derive a hash for, or
> order Rust floats. The resulting code should work even if doubles are
> contained any where in the structure.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
