[
https://issues.apache.org/jira/browse/THRIFT-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004271#comment-16004271
]
ASF GitHub Bot commented on THRIFT-3963:
----------------------------------------
GitHub user dequbed opened a pull request:
https://github.com/apache/thrift/pull/1265
THRIFT-3963 Thrift.cabal filename does not match module name
This fixes build errors when using [stack](https://haskellstack.org/)
instead of straight cabal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dequbed/thrift THRIFT-3963
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1265
----
commit 7e784c032f8f64189f55bff1b0c9e7d21c137ade
Author: Gregor Reitzenstein <[email protected]>
Date: 2017-05-10T08:02:54Z
Renames Thrift.cabal to fix THRIFT-3963
----
> Thrift.cabal filename does not match module name
> ------------------------------------------------
>
> Key: THRIFT-3963
> URL: https://issues.apache.org/jira/browse/THRIFT-3963
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 1.0
> Environment: Haskell Stack with LTS 7.7, on Ubuntu
> Reporter: Isaac Sheff
> Labels: github-import
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> Some haskell environments, including stack (http://haskellstack.org/) require
> that the cabal file name match the module name (case sensitive). This means
> that it is difficult to import the (git source repository) thrift library
> into stack projects (https://github.com/commercialhaskell/stack/issues/317).
> The fix is easy: change the name "Thrift.cabal" to "thrift.cabal."
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
