[
https://issues.apache.org/jira/browse/THRIFT-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015691#comment-16015691
]
James E. King, III commented on THRIFT-4201:
--------------------------------------------
As part of fixing this issue, let's re-enable the following tests in
{{test/known_failures_Linux.json}} and see if crosstest can prove the issue
plaguing them has been resolved:
{noformat}
grep cpp known_failures_Linux.json | grep http
"cpp-cpp_binary_http-domain",
"cpp-cpp_binary_http-ip",
"cpp-cpp_binary_http-ip-ssl",
"cpp-cpp_compact_http-domain",
"cpp-cpp_compact_http-ip",
"cpp-cpp_compact_http-ip-ssl",
"cpp-cpp_header_http-domain",
"cpp-cpp_header_http-ip-ssl",
"cpp-cpp_json_http-domain",
"cpp-cpp_json_http-ip",
"cpp-cpp_json_http-ip-ssl",
"cpp-dart_binary_http-ip",
"cpp-dart_compact_http-ip",
"cpp-dart_json_http-ip",
"cpp-go_binary_http-ip",
"cpp-go_binary_http-ip-ssl",
"cpp-go_compact_http-ip",
"cpp-go_compact_http-ip-ssl",
"cpp-go_json_http-ip",
"cpp-go_json_http-ip-ssl",
"cpp-java_binary_http-ip",
"cpp-java_binary_http-ip-ssl",
"cpp-java_compact_http-ip",
"cpp-java_compact_http-ip-ssl",
"cpp-java_json_http-ip",
"cpp-java_json_http-ip-ssl",
"d-cpp_binary_http-ip",
"d-cpp_binary_http-ip-ssl",
"d-cpp_compact_http-ip",
"d-cpp_compact_http-ip-ssl",
"d-cpp_json_http-ip",
"d-cpp_json_http-ip-ssl",
"go-cpp_binary_http-ip",
"go-cpp_binary_http-ip-ssl",
"go-cpp_compact_http-ip",
"go-cpp_compact_http-ip-ssl",
"go-cpp_json_http-ip",
"go-cpp_json_http-ip-ssl",
{noformat}
> False positive timeout or wrongly blocking recv in the THttpTransport client
> ----------------------------------------------------------------------------
>
> Key: THRIFT-4201
> URL: https://issues.apache.org/jira/browse/THRIFT-4201
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: Linux 64 bit - CentOS Linux release 7.3.1611
> Reporter: Iliya Gurov
> Labels: C++, C++11, client, http, patch, transport
> Attachments: httpTransportClientPatch.patch, uts2.pcap
>
>
> Before we get more data by doing refill in the
> *THttpTransport::readMoreData()*, we need to check whether we have already
> the entire content in the buffer (fetched in the last *::recv* in
> *TSocket::read()* while processing the previous chunk). Doing refill without
> this check may lead to calling *::recv* even though all chunks (the entire
> content) are already in the buffer. The effect of this is that the call fails
> either with a false positive timeout or blocks in recv if no timeout is
> configured.
> Attached is the suggested patch and tcpdump pcap (you can clearly see there
> that we wait for more data although we have already ACKed the last piece of
> byte - tcp.stream eq 26).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
