[
https://issues.apache.org/jira/browse/THRIFT-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033629#comment-16033629
]
Jens Geyer commented on THRIFT-4216:
------------------------------------
{quote}
Though this fix seems simple, I have not supplied a patch, as this fix should
likely be bundled with a greater overarching patch to THRIFT-4215.
{quote}
Ok, I see. But you could review the patch, comment and share your thoughts. The
more eyes we have, the more potential issues we will find & fix early.
> Golang Http Clients Do Not Respect User Options
> -----------------------------------------------
>
> Key: THRIFT-4216
> URL: https://issues.apache.org/jira/browse/THRIFT-4216
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: James Mouradian
>
> As of 72ca60d, the instantiation of an http client with user-supplied options
> ([NewTHttpClientWithOptions|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93])
> disregards options.
> The target endpoint is tested with the following snippet:
> {code}
> response, err := http.Get(urlstr)
> {code}
> However, a user-supplied {{THttpClientOptions}} contains a client that should
> be used to test the endpoint instead, i.e.,
> {code}
> response, err := options.Client.Get(urlstr)
> {code}
> The user-supplied client may have settings that are required to communicate
> with the target endpoint.
> Though this fix seems simple, I have not supplied a patch, as this fix should
> likely be bundled with a greater overarching patch to THRIFT-4215. That is
> because the single line change above may not include all the fixes necessary
> to propagate client options correctly through the construction of a
> {{THttpTransport}}, and further errors are squelched.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
