[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034550#comment-16034550
]
Mario Emmenlauer edited comment on THRIFT-2221 at 6/2/17 2:01 PM:
------------------------------------------------------------------
Dear [~jking3],
I tried the patch from
https://github.com/jeking3/thrift/commit/d6d75b42bd04cefd9eb1b7ea7b8ecdee168b7c01
against the latest thrift trunk (2b1b32c) but the build fails for me with:
{code}
In file included from
/data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/transport/TTransport.h:24:0,
from
/data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/protocol/TProtocol.h:28,
from
/data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/TApplicationException.cpp:21:
/data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/stdcxx.h:127:24: error: invalid
use of template-name ‘std::unique_ptr’ without an argument list
using scoped_ptr = std::unique_ptr;
^
{code}
Am I doing something wrong? Do I need to specifically configure cmake if I want
to use the C++11 shared_ptr?
was (Author: emmenlau):
Dear [~jking3], is there a cummulative patch with all your changes with respect
to all your C++11 related work?
> Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
> --------------------------------------------------------------------
>
> Key: THRIFT-2221
> URL: https://issues.apache.org/jira/browse/THRIFT-2221
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler
> Affects Versions: 0.9.1
> Environment: C++11 compilers with std::shared_ptr support
> Reporter: Chris Stylianou
> Assignee: James E. King, III
> Labels: c++11, compiler, thrift
>
> Most modern compilers now have full support for std::shared_ptr when enable
> with c++11 flags. It would be nice to have the option to generate code that
> uses this instead of boost::shared_ptr. This would enable us to remove
> another boost dependency, on the road to a dependency-free thrift library :)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)