[
https://issues.apache.org/jira/browse/THRIFT-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052406#comment-16052406
]
ASF GitHub Bot commented on THRIFT-4231:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1291
THRIFT-4231 TJSONProtocol throws unexpected non-Thrift-exception on n…
…ull strings
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4231
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1291
----
commit 658fad07ffe4db2932a0448b0f33ab0f55ca54db
Author: Jens Geyer <[email protected]>
Date: 2017-06-16T21:10:54Z
THRIFT-4231 TJSONProtocol throws unexpected non-Thrift-exception on null
strings
Client: C#
Patch: Jens Geyer
----
> TJSONProtocol throws unexpected non-Thrift-exception on null strings
> --------------------------------------------------------------------
>
> Key: THRIFT-4231
> URL: https://issues.apache.org/jira/browse/THRIFT-4231
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Minor
>
> When a required (e.g. string) field is not set, the C# code may throw a
> non-Thrift nullptr exception, which at this point is a bit unexpected.
> Happened to me with TJSON but is in fact a problem of required fields not
> being checked properly in the generated struct.Write() code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
