GitHub user zwass opened a pull request:
https://github.com/apache/thrift/pull/1302
THRIFT-4243 Fix Go TSimpleServer race on wait in Stop() method
Fixes the synchronization issues in the existing Stop() method, by ensuring
no
further Add calls are made to the WaitGroup at shutdown. See
https://issues.apache.org/jira/browse/THRIFT-4243 for discussion.
This also fixes https://issues.apache.org/jira/browse/THRIFT-4240.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwass/thrift THRIFT-4243
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1302
----
commit 3f0444f8292a6ca1889e9812b805759eb8a74255
Author: Zachary Wasserman <[email protected]>
Date: 2017-06-27T19:03:39Z
THRIFT-4240 Fix use of sync.Once in Go TSimpleServer Stop() method
A package global sync.Once was used, which ensured that Stop() could only be
called once *per process*. The correct semantics should be once *per
server*.
This commit makes the sync.Once a member of the server struct so that the
correct semantics are applied.
https://issues.apache.org/jira/browse/THRIFT-4240
commit 86c000892ce9d9727c0af9b737969b38541f92de
Author: Zachary Wasserman <[email protected]>
Date: 2017-06-30T00:15:01Z
THRIFT-4243 Fix Go TSimpleServer race on wait in Stop() method
Fixes the synchronization issues in the existing Stop() method, by ensuring
no
further Add calls are made to the WaitGroup at shutdown. See
https://issues.apache.org/jira/browse/THRIFT-4243 for discussion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
