Github user juliengreard commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125761010
--- Diff: test/py/SerializationTest.py ---
@@ -285,6 +290,67 @@ def testIntegerLimits(self):
for value in bad_values:
self.assertRaises(Exception, self._serialize, value)
+ def testRecTree(self):
+ """Ensure recursive tree node can be created."""
+ children = []
+ for idx in range(1, 5):
--- End diff --
where do the "5" comes from ? Is it a limit for the implementation (you
can't have recursive struct with more than 5 recursions? if so, it should be
highlighted (maybe it is already, but I didn't see it). What happens if I have
a struct with more than 5 recursions in it (i.e.
myObject.leaf.leaf.leaf.leaf.leaf.leaf.leaf.leaf is not None)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
