[ 
https://issues.apache.org/jira/browse/THRIFT-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085021#comment-16085021
 ] 

ASF GitHub Bot commented on THRIFT-4248:
----------------------------------------

GitHub user sokac opened a pull request:

    https://github.com/apache/thrift/pull/1307

    THRIFT-4248: Import cstring in TSSLSocket

    strncpy, memcmp, memset are used in TSSLSocket so cstring needs to be
    imported.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sokac/thrift fix/lib_cpp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1307
    
----
commit f2f235001c07b9be81cf3a12518533ce28767db0
Author: Josip Sokcevic <[email protected]>
Date:   2017-07-08T23:34:49Z

    THRIFT-4248: Import cstring in TSSLSocket
    
    strncpy, memcmp, memset are used in TSSLSocket so cstring needs to be
    imported.

----


> Compile fails - strncpy, memcmp, memset not declared in 
> src/thrift/transport/TSSLSocket.cpp
> -------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4248
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4248
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>            Reporter: Josip Sokcevic
>         Attachments: 0001-THRIFT-4248-Import-cstring-in-TSSLSocket.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to