[
https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895
]
Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:15 AM:
-------------------------------------------------------------
Thanks for the quick reply [~jensg]. This is the first time I am contributing
to a large C++ open source project, or writing much C++ to be honest, and it
will be good to get some guidance on development workflow. I'm assuming I clone
https://github.com/apache/thrift, make a branch and start working. Happy to
jump on some other communication medium if that is better for you.
If you spare a few minutes, it will also be nice to have a point in the code I
can start from. Thanks.
was (Author: davinc):
Thanks for the quick reply [~jensg]. This is the first time I am contributing
to a large C++ open source project, or writing much C++ to be honest, and it
will be good to get some guidance on development workflow. I'm assuming I clone
https://github.com/apache/thrift, make a branch and start working.
If you spare a few minutes, it will also be nice to have a point in the code I
can start from. Thanks.
> Go generator assigns strings to field in const instead of pointers.
> -------------------------------------------------------------------
>
> Key: THRIFT-4253
> URL: https://issues.apache.org/jira/browse/THRIFT-4253
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
> Affects Versions: 0.10.0
> Environment: Generated using docker-thrift.
> Reporter: Davin Chia
>
> Given the follow thrift definition:
> {code:java}
> struct custom {
> 1: required string field_a;
> 2: optional string field_b;
> }
> {code}
> with the following constant map defined in the same file:
> {code:java}
> const map<i32, custom> custom_map = {
> ...,
> 42 : { 'field_a':'www.testa.com', 'field_b':'www.testb.com'},
> ...,
> }
> {code}
> Thrift generates the following go struct in the main {code:java}x.go{code}
> file:
> {code:java}
> type Custom struct {
> FieldA string `thrift:"field_a,required" db:"field_a" json:"field_a"`
> FieldB *string `thrift:"field_b,2" db:"field_b" json:"field_b,omitempty"`
> }
> {code}
> with the corresponding assignments in the {code:java} X-consts.go {code} file:
> {code:java}
> CUSTOM_MAP = map[int]*Custom {
> ...,
> 42: &Custom {FieldA: "www.testa.com", FieldB: "www.testb.com"},
> ...,
> }
> {code}
> I assume field_b's pointer type is to allow for null values as per the
> optional. The generator should be assigning pointers instead of strings.
> I'm not sure how much effort it would take to fix this. I am encountering
> this problem at work right and would be very happy to starting working on
> this with some guidance from experts around here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
