Github user taozle commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1309#discussion_r128156419
  
    --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
    @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
                               "    read_write_private\n"
                               "                     Make read/write methods 
private, default is public Read/Write\n" \
                               "    use_context\n"
    -                          "                     Make service method 
receive a context as first argument.\n")
    +                          "                     Make service method 
receive a context as first argument, only go1.7+ is supported.\n")
    --- End diff --
    
    Sorry for my poor expression,  the *no dependency* i mean is that *no 
thirdparty dependency*. `use_context` can't be removed because adding context 
support breaks the backward compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to