Github user hcorg commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1328#discussion_r131968203
  
    --- Diff: lib/cpp/README.md ---
    @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent.
     
     ## Dependencies
     
    -boost shared pointers
    -http://www.boost.org/libs/smart_ptr/smart_ptr.htm
    +If your C++ environment implements C++11 or later, boost will 
automatically use
    --- End diff --
    
    Even if boost itself provides mapping to `std::` pointers, next sentence 
suggests that boost is not needed. Some little clean up could help confused 
users ;) (this is also first place in README.md where boost is mentioned, hence 
the potential confusion)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to