ASF GitHub Bot commented on THRIFT-2221:

Github user hcorg commented on a diff in the pull request:

    --- Diff: lib/cpp/README.md ---
    @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent.
     ## Dependencies
    -boost shared pointers
    +If your C++ environment implements C++11 or later, boost will 
automatically use
    --- End diff --
    Even if boost itself provides mapping to `std::` pointers, next sentence 
suggests that boost is not needed. Some little clean up could help confused 
users ;) (this is also first place in README.md where boost is mentioned, hence 
the potential confusion)

> Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
> --------------------------------------------------------------------
>                 Key: THRIFT-2221
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2221
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>         Environment: C++11 compilers with std::shared_ptr support
>            Reporter: Chris Stylianou
>            Assignee: James E. King, III
>              Labels: c++11, compiler, thrift
> Most modern compilers now have full support for std::shared_ptr when enable 
> with c++11 flags. It would be nice to have the option to generate code that 
> uses this instead of boost::shared_ptr. This would enable us to remove 
> another boost dependency, on the road to a dependency-free thrift library :)

This message was sent by Atlassian JIRA

Reply via email to