GitHub user dhull opened a pull request:

    https://github.com/apache/thrift/pull/1329

    THRIFT-4279: Fix include path in generated Erlang Thrift sources.

    The change in THRIFT-4270 inadvertantly modified the include directives in 
the generated Erlang sources to include the gen-erl directory in the path to 
the include file.  This commit restores the
    previous behavior.
    
    Example include directive before the THRIFT-4270 change:
    ```erlang
    -include("constants_demo_types.hrl").
    ```
    
    Example include directive after the THRIFT-4270 change:
    ```erlang
    -include("test/gen-erl/constants_demo_types.hrl").
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhull/thrift 
thrift-4279-erlang-fix-include-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1329.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1329
    
----
commit 4aa8fca3955ff6eb1f6cc810a8cad50a74294caa
Author: David Hull <david.h...@openx.com>
Date:   2017-08-08T17:42:37Z

    THRIFT-4279: Fix include path in generated Erlang Thrift sources.
    
    The change in THRIFT-4270 inadvertantly modified the include
    directives in the generated Erlang sources to include the gen-erl
    directory in the path to the include file.  This commit restores the
    previous behavior.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to