Github user asuhan commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1326#discussion_r132612556
  
    --- Diff: lib/cpp/test/TMemoryBufferTest.cpp ---
    @@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
       BOOST_CHECK_NO_THROW(buf2.write((const uint8_t*)"bar", 3));
     }
     
    +#ifndef _WIN32
    +// We can't allocate 1 GB of memory in 32-bit environments.
    --- End diff --
    
    We'd have to write in a loop to trigger buffer resizing if I understand 
correctly. It'd save the vector allocation in the test, but `TMemoryBuffer` 
would still grow. I agree a 50% reduction would be better than nothing, for 
sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to