[
https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123806#comment-16123806
]
ASF GitHub Bot commented on THRIFT-4284:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1330
THRIFT-4284: remove extraneous character
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4284
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1330
----
commit a6c075e38366b982dd2bbdae14fc38cb3b6a2845
Author: James E. King, III <[email protected]>
Date: 2017-08-11T18:30:41Z
THRIFT-4284: remove extraneous character
----
> File contains a NBSP: lib/nodejs/lib/thrift/web_server.js
> ---------------------------------------------------------
>
> Key: THRIFT-4284
> URL: https://issues.apache.org/jira/browse/THRIFT-4284
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2, 0.9.3, 0.10.0
> Reporter: Claudio Procida
> Assignee: James E. King, III
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This file contains a non-breaking space ({{\u00a0}}):
> {{lib/nodejs/lib/thrift/web_server.js}}
> We found the issue while bundling the npm module [thrift|https://npm.im] with
> {{browserify}}, resulting into a syntax error in the browser.
> If you look at line 287 in [the raw
> file|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD],
> there is an {{'Â'}} character between a value and the next key.
> Interestingly, the [web
> UI|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD#l287]
> doesn't show the issue.
> The [raw file on the GitHub
> mirror|https://raw.githubusercontent.com/apache/thrift/master/lib/nodejs/lib/thrift/web_server.js]
> is not garbled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
