[
https://issues.apache.org/jira/browse/THRIFT-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154752#comment-16154752
]
ASF GitHub Bot commented on THRIFT-4292:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1337#discussion_r137163110
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.cpp ---
@@ -52,6 +52,8 @@ class TimerManager::Task : public Runnable {
}
}
+ shared_ptr<Runnable> runnable() const { return runnable_; }
--- End diff --
Consider implementing an ``operator ==`` instead which compares to a
``shared_ptr<Runnable>`` thus hiding the internal details of the
``TimerManager::Task`` and simplifying the caller to ``if (task ==
ix->second)`` below. What's there works, just a suggestion - not required to
merge.
> TimerManager::remove() is not implemented
> -----------------------------------------
>
> Key: THRIFT-4292
> URL: https://issues.apache.org/jira/browse/THRIFT-4292
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Reporter: Francois Ferrand
>
> The function is currently not implemented.
> This is not critical for Thrift, since it is not used there, but prevents
> using it in thrift-based code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
