[
https://issues.apache.org/jira/browse/THRIFT-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162193#comment-16162193
]
ASF GitHub Bot commented on THRIFT-4232:
----------------------------------------
GitHub user magiccrafter opened a pull request:
https://github.com/apache/thrift/pull/1354
THRIFT-4232 ./configure does bad ant version check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/magiccrafter/thrift THRIFT-4232
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1354
----
commit e91d115f628c33c121b82c4820656861caac2e83
Author: Nasko Vasilev <[email protected]>
Date: 2017-09-11T22:40:49Z
THRIFT-4232 ./configure does bad ant version check
commit 3bbc487133b89459eb8800ebc64adf95496d4559
Author: Nasko Vasilev <[email protected]>
Date: 2017-09-11T22:57:38Z
THRIFT-4232 ./configure does bad ant version check (inclusive comparison
with >= instead of > only)
----
> ./configure does bad ant version check
> --------------------------------------
>
> Key: THRIFT-4232
> URL: https://issues.apache.org/jira/browse/THRIFT-4232
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.10.0
> Environment: OSX 10.12.5, running ant 1.10.1
> Reporter: David Woodward
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> On line 18869 of the configure script, it checks that the ant version is >=
> 1.7. It uses some kind of string comparison. This breaks for my current ant
> version (1.10). It seems to think that 1.10 is not >= 1.7. I think this is
> because it's comparing strings without taking into account what the strings
> actually mean. Something like this might be a possible patch:
> https://stackoverflow.com/questions/16989598/bash-comparing-version-numbers
> This should be fixed because it means that people with new ant versions can't
> build the java thrift library.
> Also it should be checked to see if other parts of the configure process are
> using these kinds of faulty version checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
