[
https://issues.apache.org/jira/browse/THRIFT-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165123#comment-16165123
]
ASF GitHub Bot commented on THRIFT-4327:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138711130
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -69,28 +72,33 @@ class TimerManager {
*
* @param task The task to execute
* @param timeout Time in milliseconds to delay before executing task
+ * @return Handle of the timer, which can be used to remose the timer.
--- End diff --
remose == remove?
> Improve TimerManager API to allow removing specific task
> --------------------------------------------------------
>
> Key: THRIFT-4327
> URL: https://issues.apache.org/jira/browse/THRIFT-4327
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Francois Ferrand
>
> The TimerManager::remove() method removes all timers with the specified
> callback, and does so by traversing the list of timers.
> This should be improved by returning a "handle" in `TimerManager::add`, and
> supporting efficiently removing a single timer from its handle:
> {code:java}
> class TimerManager {
> Timer add(shared_ptr<Runnable> task, const struct timeval& value);
> void remove(Timer t);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
