[
https://issues.apache.org/jira/browse/THRIFT-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4331:
---------------------------------------
Description:
The TSSLSocket class did not handle large messages, because a underlying TCP
socket may signal bytes received, while SSL_read() may not have bytes
available. After maxretries (5) the function returned -1, which got interpreted
as unsigned integer for read bytes.
Futher the waitForEvent methode, did only set THRIFT_POLLIN or THRIFT_POLLOUT,
but it gets used where SSL needs to send AND receive bytes for some operations
(like close). So in the case of write wanted, THRIFT_POLLIN is also set to
cover these read/write operations.
Pullrequest for master and 0.10.0 branch will follow.
was:
The TSSLSocket class did not handle large messages, because a underlying TCP
socket my signal bytes received, while SSL_read() may not have bytes available.
After maxretries (5) the function returned -1, which got interpreted as
unsigned integer for read bytes.
Futher the waitForEvent methode, did only set THRIFT_POLLIN or THRIFT_POLLOUT,
but it gets used where SSL needs to send AND receive bytes for some operations
(like close). So in the case of write wanted, THRIFT_POLLIN is also set to
cover these read/write operations.
Pullrequest for master and 0.10.0 branch will follow.
> C++: TSSLSockets bug in handling huge messages, bug in handling polling
> -----------------------------------------------------------------------
>
> Key: THRIFT-4331
> URL: https://issues.apache.org/jira/browse/THRIFT-4331
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Reporter: Martin Haimberger
> Attachments: 0.10.0-THRIFT-4331.patch, master-THRIFT-4331.patch
>
>
> The TSSLSocket class did not handle large messages, because a underlying TCP
> socket may signal bytes received, while SSL_read() may not have bytes
> available. After maxretries (5) the function returned -1, which got
> interpreted as unsigned integer for read bytes.
> Futher the waitForEvent methode, did only set THRIFT_POLLIN or
> THRIFT_POLLOUT, but it gets used where SSL needs to send AND receive bytes
> for some operations (like close). So in the case of write wanted,
> THRIFT_POLLIN is also set to cover these read/write operations.
> Pullrequest for master and 0.10.0 branch will follow.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
