James E. King, III created THRIFT-4338:
------------------------------------------
Summary: c_glib config.h header leaking into lib/cpp build and
others
Key: THRIFT-4338
URL: https://issues.apache.org/jira/browse/THRIFT-4338
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.10.0
Environment: docker ubuntu-xenial
Reporter: James E. King, III
Priority: Minor
I was building in lib/cpp and saw the command line contained:
{noformat}
g++ -std=c++11 -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src/thrift
-I../../../lib/c_glib/src/thrift -I/usr/include -I../../../lib/cpp/src
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I. -Wall -Wextra -pedantic -g
-O2 -Wno-deprecated-register -MT SecurityTest.o -MD -MP -MF $depbase.Tpo -c -o
SecurityTest.o SecurityTest.cpp &&\
{noformat}
In configure.ac at the global level we have:
{noformat}
AC_CONFIG_HEADERS(config.h:config.hin)
AC_CONFIG_HEADERS(lib/cpp/src/thrift/config.h:config.hin)
AC_CONFIG_HEADERS(lib/c_glib/src/thrift/config.h:config.hin)
{noformat}
This is causing the lib/cpp include path to refer to something in c_glib.
Similarly if these options carry into c_glib then a lib/cpp header would
potentially be accessible in the c_glib build.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
