[ https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175424#comment-16175424 ]
ASF GitHub Bot commented on THRIFT-4233: ---------------------------------------- Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1366 @jeking3 , please review. The static is not acceptable to getInvoker as invoker is not static context > Make THsHaServer.invoker available (get method only) in inherited classes > ------------------------------------------------------------------------- > > Key: THRIFT-4233 > URL: https://issues.apache.org/jira/browse/THRIFT-4233 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Affects Versions: 0.10.0 > Reporter: Dmitry Volodin > Assignee: James E. King, III > Priority: Minor > > In some cases (for example in Apache Camel component for Thrift) there is a > requirement, when it is necessary not only to transfer executorService from > the external system through the Args in THsHaServer , but to organize control > them from outside. In this case, it's possible to create a class which is > inherited from THsHaServer, but not possible to access invoker in overloaded > gracefullyShutdownInvokerPool(). As workaround the TNonblockingServer must be > extended but requires to create several methods from scratch. > It's necessary to add code below to THsHaServer > {code:java} > protected ExecutorService getInvoker() { > return invoker; > } > {code} > I'm ready to add this code as PR. -- This message was sent by Atlassian JIRA (v6.4.14#64029)