[ 
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176917#comment-16176917
 ] 

ASF GitHub Bot commented on THRIFT-3766:
----------------------------------------

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1370

    THRIFT-3766: add zlib getUnderlyingTransport method

    Client: C++
    
    This closes #1370

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift THRIFT-3766

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1370
    
----
commit 075579e5ad4ba6b6ed77d99b95b7bd7bdb6b9c15
Author: James E. King, III <[email protected]>
Date:   2017-09-22T18:41:10Z

    THRIFT-3766: add zlib getUnderlyingTransport method
    Client: C++
    
    This closes #1370

----


> Add getUnderlyingTransport() to TZlibTransport
> ----------------------------------------------
>
>                 Key: THRIFT-3766
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3766
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: David George
>            Assignee: James E. King, III
>            Priority: Minor
>         Attachments: zlib_getUnderlyingTransport.diff
>
>
> I currently have a service using the Zlib transport. I noticed I couldn't get 
> the client IP address as I could with TBufferedTransport using the 
> getUnderlyingTransport() function.
> I have hacked my local builds by sticking the following:
> {noformat}
> boost::shared_ptr<TTransport> getUnderlyingTransport() { return transport_; }
> {noformat}
> in TZlibTransport.h which mirrors those in TBufferTransports.h.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to