Hi, haven 't read your changes, but although I made the same proposal a while ago here are my thoughts:
a) I'm against removing the patch method entirely b) would nevertheless make clear that we absolutely prefer pull requests c) make PRs mandatory only if the patch is beyond a certain size, i.e. not a "small patch" (we need a defintion for "small patch" ...) Have fun, JensG -----Ursprüngliche Nachricht----- From: James E. King, III Sent: Friday, September 22, 2017 4:01 PM To: [email protected] Subject: Proposal: Retire the "Patch" submission method We've been using github for a while now. At this point everyone should be expected to submit changes to the project through github. Tickets in Jira that have patches without a pull request experience significant delays. I would prefer to see the Jira option for "Patch Available" removed. Folks can still attach documents to Jira items if they want for non-code related issues, however most of the time (even for this change) having an interactive review would be better/easier. To that end I have taken a stab at rewriting the How to Contribute guide. See: https://github.com/jeking3/thrift/blob/c0203dc64c3684b76b2ff7a4d537f68b9b4fe3d5/CONTRIBUTING.md I'd like to commit this so that the official page gets updated. Let me know. - Jim
