James E. King, III created THRIFT-4359:
------------------------------------------
Summary: Haxe compiler looks like it is producing incorrect code
for map or set key that is binary type
Key: THRIFT-4359
URL: https://issues.apache.org/jira/browse/THRIFT-4359
Project: Thrift
Issue Type: Bug
Components: Haxe - Compiler
Affects Versions: 0.10.0
Environment: docker ubuntu-artful; autotools
Reporter: James E. King, III
Assignee: James E. King, III
Priority: Minor
Static code analysis in the gcc 7.2 build under Ubuntu Artful pointed out a
missing break that may be cause for alarm:
https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_haxe_generator.cc#2554
https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_haxe_generator.cc#2579
It looks like if the type is a set or map, and the key is a binary, it will
fall through to an integer for handling. This seems incorrect.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
