GitHub user RobberPhex opened a pull request:

    https://github.com/apache/thrift/pull/1391

    Fix segment fault at thrift_protocol extension

    * while serialize set,
        if type at IDL is scalar, directly use key of array as element.
        if type at IDL isn't scalar, directly use value of array as element.
    * update license at config.m4
    * drop php5 support
    * after call call_user_function, detect EG(exception)
    * zend_read_static_property without silent, cause a EG(exception).
    * when serialize set at extension, pass sub-fieldspec to 
inner-serialize.(do not pass nullptr)
    * when validate_thrift_object, if there is no isValidate, skip validate.
    * add thrift_protocol_read_binary_after_message_begin for deserialize 
without method name.
    
    --
    
    close #1383 #1385 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RobberPhex/thrift fix-php-ext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1391
    
----
commit 5fbac48320a042b1d6b8724a796b313cea0f2085
Author: 董菲 <[email protected]>
Date:   2016-11-16T02:32:52Z

    support php ext read data after message begin

commit d4e29d51da74ecf01a0f8c3921c2f1ff4f37f2c6
Author: 董菲 <[email protected]>
Date:   2016-11-16T02:50:22Z

    fix

commit 38cc17b8b3ff3e63c0616a5b98c76640bdedebb7
Author: 董菲 <[email protected]>
Date:   2016-11-16T03:53:19Z

    fix

commit ee55504b8623414446b78dd6251ad7b1517d1d1e
Author: Robert Lu <[email protected]>
Date:   2017-10-03T19:18:38Z

    compiler use thrift_protocol_read_binary_after_message_begin

commit d76995b56abd9acdacf99e0c443e6f24e182ed9b
Author: Robert Lu <[email protected]>
Date:   2017-10-04T16:17:15Z

    if is_validate is not defined
    
    if isValidate is unset, and last arg of zend_read_static_property is false,
    EG(exception) will be set.
    
    So, set last arg of zend_read_static_property to true, and check 
is_validate is null

commit a6b669a62eb7d2d5d983ab823ceb6a8b8fa07cf8
Author: Robert Lu <[email protected]>
Date:   2017-10-04T17:38:17Z

    fix segment caused by zend_read_static_property
    
    * zend_read_static_property with slient(last arg) false, maybe set 
EG(exception)
    * sometimes, we accept unset static property, so call 
zend_read_static_property with slient(last arg) true

commit 3d03cd9f77e0b772964ccea6ce8cde16a792b8b8
Author: 董菲 <[email protected]>
Date:   2016-11-24T09:42:46Z

    fix referenced value error

commit 1531b2c76d353b338cd40fc5b5b7326e92ade692
Author: Robert Lu <[email protected]>
Date:   2017-10-04T15:49:01Z

    add exception detection after call user funciton

commit 0433fa63bd40411a01b42888126ade969f6615e5
Author: Robert Lu <[email protected]>
Date:   2017-10-09T11:52:34Z

    detect is_scalar while compile

commit d90999173928bdbfbe124002e8833627962a0d16
Author: Robert Lu <[email protected]>
Date:   2017-10-09T11:55:43Z

    fix list in set

commit 36e8e36b4db851c31c1f84961d61ac7cc92fdda3
Author: Robert Lu <[email protected]>
Date:   2017-10-11T07:05:31Z

    remove tail tab

commit 2d8cf19bc9085d2b30aed9a1c7de99472f1ec6fe
Author: Robert Lu <[email protected]>
Date:   2017-10-12T08:48:21Z

    process PHPExceptionWrapper

commit 05b5d6bee3aa3e629b4e799f4106da61f532b72b
Author: Robert Lu <[email protected]>
Date:   2017-10-13T02:58:37Z

    remove php5 support

commit 05873ef0afe7702f4a049b2d2a681007bf425167
Author: Robert Lu <[email protected]>
Date:   2017-10-13T03:03:30Z

    update license

----


---

Reply via email to