[
https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213975#comment-16213975
]
ASF GitHub Bot commented on THRIFT-4305:
----------------------------------------
GitHub user dhasenan opened a pull request:
https://github.com/apache/thrift/pull/1396
THRIFT-4305 Doc comments in dlang output
Thrift IDL supports documentation comments. D supports doc comments.
So let's copy them over!
Future directions: add function parameter docs. ddoc expects them in
a particular format.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhasenan/thrift THRIFT-4305
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1396
----
commit eced8542e6900375716ce9dbbfc8ec9c985c27a0
Author: dhasenan <[email protected]>
Date: 2017-10-21T15:25:14Z
THRIFT-4305 Doc comments in dlang output
Thrift IDL supports documentation comments. D supports doc comments.
So let's copy them over!
Future directions: add function parameter docs. ddoc expects them in
a particular format.
----
> Emit ddoc for generated items
> -----------------------------
>
> Key: THRIFT-4305
> URL: https://issues.apache.org/jira/browse/THRIFT-4305
> Project: Thrift
> Issue Type: Improvement
> Components: D - Compiler
> Affects Versions: 0.10.0
> Reporter: Neia Neutuladh
> Attachments: THRIFT-4305 dlang documentation comments.diff
>
>
> Since Thrift IDL supports doc comments, and D supports doc comments, it would
> be great if we would actually emit Thrift's doc comments in the generated D
> code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
