[
https://issues.apache.org/jira/browse/THRIFT-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218621#comment-16218621
]
James E. King, III commented on THRIFT-4370:
--------------------------------------------
Running flake8 on test/py yields a lot of new issues:
{noformat}
root@678d13d5f3b9:/thrift/src# flake8 --ignore=E501 test/py | cut -d' ' -f2 |
sort | uniq
E303
E305
E722
F401
F403
F405
F811
W391
{noformat}
Details (just for the Recursive.thrift generated files):
{noformat}
test/py/gen-py-default/Recursive/ttypes.py:9:1: F401
'thrift.Thrift.TMessageType' imported but unused
test/py/gen-py-default/Recursive/ttypes.py:9:1: F401 'thrift.Thrift.TException'
imported but unused
test/py/gen-py-default/Recursive/ttypes.py:9:1: F401
'thrift.Thrift.TApplicationException' imported but unused
test/py/gen-py-default/Recursive/ttypes.py:9:1: F401
'thrift.Thrift.TFrozenDict' imported but unused
test/py/gen-py-default/Recursive/ttypes.py:10:1: F401
'thrift.protocol.TProtocol.TProtocolException' imported but unused
test/py/gen-py-default/Recursive/ttypes.py:13:1: F401 'sys' imported but unused
test/py/gen-py-default/Recursive/ttypes.py:27:5: E303 too many blank lines (2)
test/py/gen-py-default/Recursive/ttypes.py:103:5: E303 too many blank lines (2)
test/py/gen-py-default/Recursive/ttypes.py:170:5: E303 too many blank lines (2)
test/py/gen-py-default/Recursive/ttypes.py:227:5: E303 too many blank lines (2)
test/py/gen-py-default/Recursive/ttypes.py:284:5: E303 too many blank lines (2)
test/py/gen-py-default/Recursive/ttypes.py:340:1: E305 expected 2 blank lines
after class or function definition, found 0
test/py/gen-py-default/Recursive/constants.py:9:1: F401
'thrift.Thrift.TMessageType' imported but unused
test/py/gen-py-default/Recursive/constants.py:9:1: F401
'thrift.Thrift.TException' imported but unused
test/py/gen-py-default/Recursive/constants.py:9:1: F401 'thrift.Thrift.TType'
imported but unused
test/py/gen-py-default/Recursive/constants.py:9:1: F401
'thrift.Thrift.TApplicationException' imported but unused
test/py/gen-py-default/Recursive/constants.py:9:1: F401
'thrift.Thrift.TFrozenDict' imported but unused
test/py/gen-py-default/Recursive/constants.py:10:1: F401
'thrift.protocol.TProtocol.TProtocolException' imported but unused
test/py/gen-py-default/Recursive/constants.py:11:1: F401
'thrift.TRecursive.fix_spec' imported but unused
test/py/gen-py-default/Recursive/constants.py:13:1: F401 'sys' imported but
unused
test/py/gen-py-default/Recursive/constants.py:14:1: F403 'from .ttypes import
*' used; unable to detect undefined names
test/py/gen-py-default/Recursive/constants.py:14:1: F401 '.ttypes.*' imported
but unused
test/py/gen-py-default/Recursive/TestService.py:9:1: F401
'thrift.Thrift.TException' imported but unused
test/py/gen-py-default/Recursive/TestService.py:9:1: F401
'thrift.Thrift.TFrozenDict' imported but unused
test/py/gen-py-default/Recursive/TestService.py:10:1: F401
'thrift.protocol.TProtocol.TProtocolException' imported but unused
test/py/gen-py-default/Recursive/TestService.py:13:1: F401 'sys' imported but
unused
test/py/gen-py-default/Recursive/TestService.py:15:1: F403 'from .ttypes import
*' used; unable to detect undefined names
test/py/gen-py-default/Recursive/TestService.py:235:5: E303 too many blank
lines (2)
test/py/gen-py-default/Recursive/TestService.py:249:33: F405 'RecTree' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:283:1: E305 expected 2 blank
lines after class or function definition, found 0
test/py/gen-py-default/Recursive/TestService.py:286:32: F405 'RecTree' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:297:5: E303 too many blank
lines (2)
test/py/gen-py-default/Recursive/TestService.py:311:36: F405 'RecTree' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:345:1: E305 expected 2 blank
lines after class or function definition, found 0
test/py/gen-py-default/Recursive/TestService.py:347:35: F405 'RecTree' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:358:5: E303 too many blank
lines (2)
test/py/gen-py-default/Recursive/TestService.py:372:32: F405 'RecList' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:406:1: E305 expected 2 blank
lines after class or function definition, found 0
test/py/gen-py-default/Recursive/TestService.py:409:31: F405 'RecList' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:420:5: E303 too many blank
lines (2)
test/py/gen-py-default/Recursive/TestService.py:434:36: F405 'RecList' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:468:1: E305 expected 2 blank
lines after class or function definition, found 0
test/py/gen-py-default/Recursive/TestService.py:470:35: F405 'RecList' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:481:5: E303 too many blank
lines (2)
test/py/gen-py-default/Recursive/TestService.py:495:33: F405 'CoRec' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:529:1: E305 expected 2 blank
lines after class or function definition, found 0
test/py/gen-py-default/Recursive/TestService.py:532:32: F405 'CoRec' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:543:5: E303 too many blank
lines (2)
test/py/gen-py-default/Recursive/TestService.py:557:36: F405 'CoRec' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:591:1: E305 expected 2 blank
lines after class or function definition, found 0
test/py/gen-py-default/Recursive/TestService.py:593:35: F405 'CoRec' may be
undefined, or defined from star imports: .ttypes
test/py/gen-py-default/Recursive/TestService.py:597:1: W391 blank line at end
of file
{noformat}
As such I am going to disable flake8 on test/py and open a backlog item in Jira
to re-enable it.
> Ubuntu Artful cppcheck and flake8 are more stringent and causing SCA build
> job failures
> ---------------------------------------------------------------------------------------
>
> Key: THRIFT-4370
> URL: https://issues.apache.org/jira/browse/THRIFT-4370
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.11.0
> Environment: docker ubuntu-artful
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Blocker
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
