[
https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221464#comment-16221464
]
ASF GitHub Bot commented on THRIFT-4373:
----------------------------------------
Github user sokac commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147295629
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -537,6 +537,9 @@ void binary_deserialize(int8_t thrift_typeID,
PHPInputTransport& transport, zval
}
zval* spec = zend_read_static_property(Z_OBJCE_P(return_value),
"_TSPEC", sizeof("_TSPEC")-1, false);
+ if (spec) {
--- End diff --
ZVAL_DEREF checks is reference:
https://github.com/php/php-src/blob/ffc734b2a455e2f2748f18a54ab597f7e0c715ba/Zend/zend_types.h#L944
I removed if statement
> Extending Thrift class results in "Attempt serialize from non-Thrift object"
> ----------------------------------------------------------------------------
>
> Key: THRIFT-4373
> URL: https://issues.apache.org/jira/browse/THRIFT-4373
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.10.0
> Environment: Linux 4.13.3-1-ARCH
> PHP 7.1.10
> Reporter: Josip Sokcevic
> Attachments: 0001-THRIFT-4373-Derefer-PHP-zval-_TSPEC.patch
>
>
> This happens when using php extension. thrift_protocol_write_binary will
> check Z_TYPE_P of spec and expects to be array (IS_ARRAY). However, PHP7 will
> set it as reference (IS_REFERENCE).
> Example:
> {code}
> $s = new Serializer\TBinarySerializer();
> // Foo is a Thrift type class
> class FooExtended extends Foo {}
> $o = new Foo();
> $o2 = new FooExtended();
> // this works just fine:
> $s->serialize($o); // this uses thrift_protocol_write_binary if available
> // Next line throws \Thrift\Exception\TProtocolException if
> thrift_protocol_write_binary is used
> // However, it doesn't break if no extension is available.
> $s->serialize($o);
> {code}
> Proposed solution is to dereference using ZVAL_DEREF before checking types
> (attached). Alternative would be to mark struct type classes as final, but
> that break compatibility.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
