[
https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223542#comment-16223542
]
ASF GitHub Bot commented on THRIFT-3773:
----------------------------------------
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r147555608
--- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc ---
@@ -95,19 +110,20 @@ class t_swift_generator : public t_oop_generator {
void generate_xception(t_struct* txception);
void generate_service(t_service* tservice);
- void print_const_value(ostream& out,
- string name,
- t_type* type,
- t_const_value* value,
- bool defval = false,
- bool is_property = false);
+ // void print_const_value(ostream& out,
+ // string name,
+ // t_type* type,
+ // t_const_value* value,
+ // bool defval = false,
+ // bool is_property = false);
--- End diff --
Can you remove commented out code, if useless ? Otherwise please put a
comment as to why we need to keep it as a comment.
> Swift Library
> -------------
>
> Key: THRIFT-3773
> URL: https://issues.apache.org/jira/browse/THRIFT-3773
> Project: Thrift
> Issue Type: New Feature
> Components: Swift - Library
> Reporter: Thomas Bartelmess
> Assignee: Chris Simpson
>
> We already have the option to generate Swift code in the Cocoa compiler,
> however large parts of the (Objective-C) Cocoa Library still depend on Cocoa
> and Objective-C.
> It would be good to have a native Swift library that doesn't depend on the
> Cocoa libraries.
> Design goals:
> - Fully compatible with the code that is currently generated by the Cocoa
> compiler (both Objective-C and Swift).
> - Ability to run on Linux
> - Pure Swift, no Objective-C code.
> - No dependencies on closed source apple libraries
> - Keep the same interface, so that the library is compatible with the code
> the current cocoa compiler generates
> - Better server support that the current Objective-C library.
> - Follow the new Swift packaging format to be compatible with the Swift
> Package manager
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
