[
https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223565#comment-16223565
]
ASF GitHub Bot commented on THRIFT-2998:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1403
THRIFT-2998, combined #378 with enabling nodejs in make cross
Yes, one little dlang warning fix slipped in there too. :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift test-THRIFT-2998
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1403
----
commit 016aa97737c8cbeed2eb3312481d7c90953a4f15
Author: stanevt <[email protected]>
Date: 2015-02-13T15:45:59Z
THRIFT-2998: Set Content-Type for HTTP request in Node.js wrapper.
Client: nodejs
This closes #378
commit 807396ea90e0c05dcbca568f3fe45e2af9cf5e61
Author: James E. King, III <[email protected]>
Date: 2017-10-26T04:09:34Z
THRIFT-2998: enable cross test for nodejs http transport,
fix missing apache license headers in nodejs
Client: nodejs
----
> Node.js: Missing header from http request
> -----------------------------------------
>
> Key: THRIFT-2998
> URL: https://issues.apache.org/jira/browse/THRIFT-2998
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Reporter: Traian Stanev
> Assignee: James E. King, III
> Priority: Minor
>
> The "Content-Type" header is not being set to "application/x-thrift" when
> making http requests in the node.js implementation. This results in error
> response (status 400) for any such connections (depending on whether the
> server checks the header). The Python implementation for example adds the
> header explicitly:
> https://github.com/tstanev/thrift/blob/master/lib/py/src/transport/THttpClient.py#L127
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
