[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

[elprans]

Github user elprans commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1274#discussion_r147559529
  
    --- Diff: lib/py/src/protocol/TProtocol.py ---
    @@ -118,6 +118,8 @@ def writeDouble(self, dub):
             pass
     
         def writeString(self, str_val):
    +        if isinstance(str_val, bytes):
    +            str_val = str_val.decode('utf8')
    --- End diff --
    
    It does, yes.  And its absence breaks py3.6.  I'm working on a fix for this.


---