Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1410#discussion_r148790668
  
    --- Diff: lib/cl/externals/software/bordeaux-threads-v0.8.5/.travis.yml ---
    @@ -0,0 +1,44 @@
    +language: lisp
    --- End diff --
    
    If you checked in bordeaux-threads, it should not be part of the 
submission.  Instead, the build process should install it on demand in the same 
manner that the nodejs implementation calls npm to install packages during the 
build.


---

Reply via email to