[GitHub] thrift pull request #1433: fix plugin.thrift, plugin{,output}.cc to use t_co...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1433#discussion_r154483874
  
    --- Diff: compiler/cpp/test/plugin/conversion_test.cc ---
    @@ -269,6 +269,12 @@ void test_const_value(t_const_value* sut) {
         T_CONST_VALUE_CASE(CV_INTEGER, integer);
         T_CONST_VALUE_CASE(CV_DOUBLE, double);
         T_CONST_VALUE_CASE(CV_STRING, string);
    +
    +#if 0
    --- End diff --
    
    Don't check in dead code.


---