[
https://issues.apache.org/jira/browse/THRIFT-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288346#comment-16288346
]
ASF GitHub Bot commented on THRIFT-4421:
----------------------------------------
GitHub user chetmurthy opened a pull request:
https://github.com/apache/thrift/pull/1443
THRIFT-4421 golang tests rely on gomock, which has change behaviour, …
…causing tests to fail
After each call to mockCtrl.Finish() where the controller might get used
later, put line
mockCtrl = gomock.NewController(t)
to create a new mockCtrl.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chetmurthy/thrift
THRIFT-4421-golang-tests-rely-on-gomock-causing-tests-to-fail
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1443.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1443
----
commit bc2c124a2739b2d419965f70d06353627f99d27c
Author: Chet Murthy <[email protected]>
Date: 2017-12-12T22:00:50Z
THRIFT-4421 golang tests rely on gomock, which has change behaviour,
causing tests to fail
After each call to mockCtrl.Finish() where the controller might get used
later, put line
mockCtrl = gomock.NewController(t)
to create a new mockCtrl.
----
> golang tests rely on gomock, which has change behaviour, causing tests to fail
> ------------------------------------------------------------------------------
>
> Key: THRIFT-4421
> URL: https://issues.apache.org/jira/browse/THRIFT-4421
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.10.0, 0.11.0
> Environment: Ubuntu 16.04.3 amd64
> Reporter: Chet Murthy
>
> Golang gomock's Controller object no longer allows multiple invocations of
> Finish(). But the lib/go unit-tests use this idiom. So change that
> (trivial).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
