Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1445#discussion_r158937524
  
    --- Diff: build/docker/run.sh ---
    @@ -25,6 +25,8 @@ DOCKER_TAG=$DOCKER_REPO:$DISTRO
     
     printenv | sort
     
    +composer install
    --- End diff --
    
    This looks like it should be part of the php section of the Dockerfile.  By 
putting it in the run section, we run "composer install" on the host and then 
start a docker environment which doesn't have access to it.


---

Reply via email to