[
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313039#comment-16313039
]
ASF GitHub Bot commented on THRIFT-4390:
----------------------------------------
GitHub user allengeorge opened a pull request:
https://github.com/apache/thrift/pull/1458
THRIFT-4390: Fix bug where binary/buffered messages > 4K could not be
read/written
Client: rs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/allengeorge/thrift thrift-4390
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1458
----
commit b4a7fc785de82cd18ef6f56864d7e04ebeaea233
Author: Allen George <allen.george@...>
Date: 2017-12-11T16:44:11Z
THRIFT-4390: Fix bug where binary/buffered messages > 4K could not be
read/written
Client: rs
----
> Rust binary protocol and buffered transport cannot handle writes above 4096
> bytes
> ---------------------------------------------------------------------------------
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
> Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
> Reporter: James E. King, III
> Assignee: Allen George
> Priority: Critical
>
> While working on improving test coverage and fixing busted cross tests I
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16,
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126,
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing
> with the interop against c_glib recently. It is the root cause of some (if
> not all of) the rs-csharp test failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
