Github user stigsb commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1340#discussion_r160168091
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -242,8 +242,10 @@ public function open()
throw new TException($error);
}
- $socket = socket_import_stream($this->handle_);
- socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
+ if (function_exists('socket_import_stream') &&
function_exists('socket_set_option')) {
--- End diff --
In high-traffic situations, this change can create a TIME_WAIT pileup.
0.11.0 is unusable for us because of this issue, please either revert or make
it configurable defaulting to off.
---
