[
https://issues.apache.org/jira/browse/THRIFT-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317111#comment-16317111
]
ASF GitHub Bot commented on THRIFT-4443:
----------------------------------------
GitHub user KerriDevine opened a pull request:
https://github.com/apache/thrift/pull/1460
THRIFT-4443: Implement skip function in json_protocol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KerriDevine/thrift THRIFT-4443
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1460
----
commit d68aad85cb5852bffc961103e0ffbdd34398d39d
Author: Kerri Devine <kerri.devine@...>
Date: 2018-01-05T23:04:46Z
THRIFT-4443: Implement skip function in json_protocol
----
> node.js json_protocol throws error in skip function
> ---------------------------------------------------
>
> Key: THRIFT-4443
> URL: https://issues.apache.org/jira/browse/THRIFT-4443
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.11.0
> Reporter: Kerri Devine
> Labels: easyfix, patch
> Fix For: 0.12.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The skip function is unsupported in the node.js implementation of the
> json_protocol. Interestingly, the compact_protocol implements the skip
> function, as does the JavaScript version.
> {code:javascript}
> TJSONProtocol.prototype.skip = function(type) {
> throw new Error('skip not supported yet');
> };
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
