[
https://issues.apache.org/jira/browse/THRIFT-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321438#comment-16321438
]
ASF GitHub Bot commented on THRIFT-4295:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1340#discussion_r160835825
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -242,8 +242,10 @@ public function open()
throw new TException($error);
}
- $socket = socket_import_stream($this->handle_);
- socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
+ if (function_exists('socket_import_stream') &&
function_exists('socket_set_option')) {
--- End diff --
I'd like to know a little more. If the functions don't exist they cannot
be called. Is the problem that function_exists is returning the wrong result?
> Refresh the Docker image file suite for Ubuntu, Debian, and CentOS
> ------------------------------------------------------------------
>
> Key: THRIFT-4295
> URL: https://issues.apache.org/jira/browse/THRIFT-4295
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Affects Versions: 0.11.0
> Environment: docker, travis
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Critical
> Labels: centos, debian, docker, travis-ci, ubuntu
> Fix For: 0.11.0
>
>
> The docker build images are in need of some much needed updating to avoid CI
> build issues.
> centos is getting updates for cmake, gcc, go, and others as well as working
> around the epel issue with nodejs and http_parser
> debian is being updated from jessie (8) to stretch (9.1)
> ubuntu is being updated from 14.04 to 16.04
> The previous images will still be available:
> centos6 will remain untouched, however the last remaining build job
> validating python 2.6 is going to be removed
> debian8 will be there for jessie, however we will not build packages from it
> any more
> ubuntu1404 will be there for trusty, however we will not build using it any
> more
> So far here's what's on the ubuntu 16.04 xenial docker image:
> {noformat}
> C++ (C++11 default) gcc-5.4.0, clang-3.8
> C# mono 5.2.0.215
> c_glib 2.0
> d 2.075.1
> dart 1.24.2
> erlang 18.3
> go 1.6.2
> haskell 7.10.3
> haxe 3.2.1
> java 1.8.0_131
> lua 5.3
> nodejs 8.4.0
> perl 5.22.1
> php 7.0.22
> python 2.7.12, 3.5.2
> ruby 2.3.1p112
> rust 1.15.1
> Intentionally leaving this out, for now (it wasn't in the trusty docker image
> either):
> dotnet 2.0.0
> Not in any images:
> cocoa
> smalltalk
> swift
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
