[
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322347#comment-16322347
]
ASF GitHub Bot commented on THRIFT-4448:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1459
My thoughts after sleeping on it are that we should support the current
Ubuntu LTS. That said, I have no problem telling folks not to use the ancient
golang included in the LTS and to use something newer from either an Ubuntu PPA
or directly form golang sources.
I also found evidence in a number of other projects that support for golang
1.6 was dropped. So if you want to fix this in the way suggested, you will
need to update the ubuntu-xenial Dockerfile to use golang 1.7 instead, and you
should update the top level LANGUAGES.md file, add a breaking change note into
the lib/go README file, and update the build/docker/README.md file. Thanks.
> Golang: do something with context.Context
> -----------------------------------------
>
> Key: THRIFT-4448
> URL: https://issues.apache.org/jira/browse/THRIFT-4448
> Project: Thrift
> Issue Type: Task
> Components: Go - Library
> Affects Versions: 0.11.0
> Reporter: John Boiles
>
> PR Here: https://github.com/apache/thrift/pull/1459
> This patch wires through {{context.Context}} such that it can be used in in
> {{http.Request}}'s {{WithContext}} method. This allows Thrift HTTP requests
> to canceled or timed out via the context.
> This patch breaks support for go<1.7 so it's not ready to ship, but I'm
> hoping to get some direction on this. When does Thrift expect to drop support
> of go1.7? It looks like the current solution is to duplicate files that need
> to use {{golang.org/x/net/context}} and add a {{// +build !go1.7}} but
> duplication seems unsustainable as the {{context}} package is imported more
> places.
> Go 1.7 was released 15 August 2016. Given Golang has had significant
> performance improvements in most dot releases, I suspect most production
> services stay reasonably up to date. Here at Periscope/Twitter we're on
> go1.9.1, and we're a fairly large organization.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
