[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323307#comment-16323307
]
ASF GitHub Bot commented on THRIFT-4434:
----------------------------------------
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
@jeking3 - It seems that fix for csharp lib tests with Tls1.2 can take more
time and investigation because of possible situation that mono implements Tls1
- 1.2 in very specific way.
Few issues related to that:
- https://bugzilla.xamarin.com/show_bug.cgi?id=42805
- https://forums.xamarin.com/discussion/57683/tls-1-2-support
- http://www.mono-project.com/docs/about-mono/releases/4.8.0/#tls-12-support
- https://boringssl.googlesource.com/boringssl/
So, the simplest fix - I just reused Tls1 for .Net Core tests (by default
for .Net Core implementation uses Tls 1.2).
At least, .Net Core client will be able to connect to old csharp server.
But to fix a csharp client, a lot of checks should be done, also maybe some
specific modification of build process (building of boringssl, etc.) should be
done too.
Updated known_failures_Linux.json with issues related to described problem.
I think checking fix for this bug in csharp/mono is for another task and
time.
> Update .NET Core components, add tests for .Net Core library and .Net Core
> compiler, fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4434
> URL: https://issues.apache.org/jira/browse/THRIFT-4434
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Compiler, .NETCore - Library, Build Process
> Environment: Windows, Linux, MacOS
> Reporter: Volodymyr Gotra
> Assignee: Volodymyr Gotra
> Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core
> compiler and quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related
> to porting of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
