[
https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323507#comment-16323507
]
ASF GitHub Bot commented on THRIFT-4452:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1464
THRIFT-4452: optimize Dockerfile
Docker build flow:
1. add all repo
2. `apt-get update` (only one time)
3. install dependencies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift dockerfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1464
----
commit a15a2d9bc2e952d984d20a08b7750eac24a3fa09
Author: Robert Lu <robberphex@...>
Date: 2018-01-05T05:44:38Z
optimize Dockerfile
----
> optimize Dockerfile (only onetime apt-get update)
> -------------------------------------------------
>
> Key: THRIFT-4452
> URL: https://issues.apache.org/jira/browse/THRIFT-4452
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Affects Versions: 0.11.0
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Minor
>
> When build
> [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile],
> there are many times to run apt-get update.
> We can just run one time apt-get update after add all repo.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
