[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324417#comment-16324417
]
ASF GitHub Bot commented on THRIFT-4434:
----------------------------------------
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1449
Yes - it can be (if such self-signed certs are not trusted and if it not
possible to build and validate the chain - but we cannot change that, because
this will cause security problems at productions)
I'm waiting for the results of cross tests - if they will be successful -
then we can say that everything is good.
Locally, I cannot reproduce any problem with set of few languages (cpp, c,
csharp, rust, netcore, ...) for cross tests.
And you can approve current pull request :) Will be a good gift for people
which want to reuse .Net Core Thrift and migrate their infrastructures to the
latest stable stack for .Net
> Update .NET Core components, add tests for .Net Core library and .Net Core
> compiler, fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4434
> URL: https://issues.apache.org/jira/browse/THRIFT-4434
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Compiler, .NETCore - Library, Build Process
> Environment: Windows, Linux, MacOS
> Reporter: Volodymyr Gotra
> Assignee: Volodymyr Gotra
> Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core
> compiler and quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related
> to porting of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)