Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373415
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests
-GENDIR = $(TESTDIR)/gen-netcore
-
THRIFTCODE = \
- Thrift/Thrift.csproj \
--- End diff --
I don't think this is correct, removing all the dependencies here. This
means if a source code file changes but the project stays the same, make won't
trigger a netcore build - it will think the target is up to date. In the merge
I am including both, and adding three missing source code files. Because of
this, I am going to have to submit a CI for the merge to make sure it works.
---
