[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

[jeking3]

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1449
  
    Okay, well, I squashed it all and found the following issues:
    
    1. I don't see any netcore tests being run in the autotools build (make 
check).  It builds some things but I don't see any test output?
    
    ```
    Making check in netcore
    make[2]: Entering directory '/thrift/src/test/netcore'
    Making check in .
    make[3]: Entering directory '/thrift/src/test/netcore'
    /usr/bin/dotnet build
    [?1h=[?1h=[?1h=[?1h=[?1h=[?1h=Microsoft (R) Build Engine 
version 15.4.8.50001 for .NET Core
    
    Copyright (C) Microsoft Corporation. All rights reserved.
    
    
    [?1h=[?1h=[?1h=[?1h=[?1h=  Thrift -> 
/thrift/src/lib/netcore/Thrift/bin/Debug/netstandard2.0/Thrift.dll
    [?1h=ThriftTest/Xception.cs(50,29): warning CS0114: 
'Xception.Message' hides inherited member 'Exception.Message'. To make the 
current member override that implementation, add the override keyword. 
Otherwise add the new keyword. [/thrift/src/test/netcore/Server/Server.csproj]
      [WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator 
named 'noexist' could be found!
      [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not 
accept 'noexist' as sub-namespace!
    [?1h=ThriftTest/Xception.cs(50,29): warning CS0114: 
'Xception.Message' hides inherited member 'Exception.Message'. To make the 
current member override that implementation, add the override keyword. 
Otherwise add the new keyword. [/thrift/src/test/netcore/Client/Client.csproj]
    [?1h=[?1h=  [WARNING:/thrift/src/test/ThriftTest.thrift:45] No 
generator named 'noexist' could be found!
      [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not 
accept 'noexist' as sub-namespace!
      Server -> 
/thrift/src/test/netcore/Server/bin/Debug/netcoreapp2.0/Server.dll
      Client -> 
/thrift/src/test/netcore/Client/bin/Debug/netcoreapp2.0/Client.dll
    
    Build succeeded.
    
    ThriftTest/Xception.cs(50,29): warning CS0114: 
'Xception.Message' hides inherited member 'Exception.Message'. To make the 
current member override that implementation, add the override keyword. 
Otherwise add the new keyword. [/thrift/src/test/netcore/Server/Server.csproj]
    ThriftTest/Xception.cs(50,29): warning CS0114: 'Xception.Message' hides 
inherited member 'Exception.Message'. To make the current member override that 
implementation, add the override keyword. Otherwise add the new keyword. 
[/thrift/src/test/netcore/Client/Client.csproj]
        2 Warning(s)
        0 Error(s)
    
    Time Elapsed 00:00:10.96
    make[3]: Leaving directory '/thrift/src/test/netcore'
    make[2]: Leaving directory '/thrift/src/test/netcore'
    ```
    
    2. The Makefile.am in lib/netcore, test/netcore, and tutorial/netcore have 
issues.  They should always be running DOTNETCORE build instead of having any 
dependencies, and the EXTRA_DIST lists are incomplete.
    
    I can clean up item #2 easily enough but I will need you to fix up item #1 
or prove to me the unit tests are being executed.


---