[
https://issues.apache.org/jira/browse/THRIFT-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326138#comment-16326138
]
ASF GitHub Bot commented on THRIFT-4459:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1471
THRIFT-4459: reduce php library directory depth
ref: https://issues.apache.org/jira/browse/THRIFT-4459
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift reduce-dir-depth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1471
----
commit 2a48ee8cdadbf52bf9af22a70f99922b972e39f8
Author: Robert Lu <robberphex@...>
Date: 2017-11-03T04:27:31Z
reduce php library directory depth
----
> reduce php library directory depth
> ----------------------------------
>
> Key: THRIFT-4459
> URL: https://issues.apache.org/jira/browse/THRIFT-4459
> Project: Thrift
> Issue Type: Improvement
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Minor
>
> The `lib/php` directory is too deep to navigate.
> Before, `TBufferedTransport.php` is located at
> `lib/php/lib/Thrift/Transport`, which is five level. and `lib/php/lib` has
> only `Thrift` folder. So, I think it's unnecessary.
> After, `lib/php/lib/Transport` is four level.
> And ClassLoader works.
> BTW, if the deep directory is necessary, I can add it back.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
