[
https://issues.apache.org/jira/browse/THRIFT-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Lu updated THRIFT-4463:
------------------------------
Description:
When use thrift compiler to generate PHP code, there are many issues doesn't
match [PSR-2|http://www.php-fig.org/psr/psr-2/]
* indent by 2 spaces, PSR-2 require 4 spaces.
* Opening brace should be on a new line (for function)
* The static declaration must come after the visibility declaration
* etc.
So, we can make generated code more readable, match PSR-2(almost).
was:
Whe use thrift compiler to generate PHP code, there are many issues doesn't
match [PSR-2|[http://www.php-fig.org/psr/psr-2/]:]
* indent by 2 spaces, PSR-2 require 4 spaces.
* Opening brace should be on a new line (for function)
* The static declaration must come after the visibility declaration
* etc.
So, we can make generated code more readable, match PSR-2(almost).
> PHP generated code match PSR-2
> ------------------------------
>
> Key: THRIFT-4463
> URL: https://issues.apache.org/jira/browse/THRIFT-4463
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler
> Affects Versions: 0.11.0
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Minor
>
> When use thrift compiler to generate PHP code, there are many issues doesn't
> match [PSR-2|http://www.php-fig.org/psr/psr-2/]
> * indent by 2 spaces, PSR-2 require 4 spaces.
> * Opening brace should be on a new line (for function)
> * The static declaration must come after the visibility declaration
> * etc.
>
> So, we can make generated code more readable, match PSR-2(almost).
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
