[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331864#comment-16331864
]
ASF GitHub Bot commented on THRIFT-4464:
----------------------------------------
GitHub user tomtung opened a pull request:
https://github.com/apache/thrift/pull/1475
THRIFT-4464: Fix typo in TNonblockingServer.py
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tomtung/thrift patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1475
----
commit 8c4ed2c965a00885ce7cf0cc578f8b96a58d842f
Author: Yubing Dong (Tom) <tomtung@...>
Date: 2018-01-19T07:55:24Z
THRIFT-4464: Fix typo in TNonblockingServer.py
----
> Potentially server-crashing typo in Python TNonblockingServer
> -------------------------------------------------------------
>
> Key: THRIFT-4464
> URL: https://issues.apache.org/jira/browse/THRIFT-4464
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.11.0
> Environment: n/a
> Reporter: Tom Dong
> Priority: Major
> Labels: EasyFix, Typo
>
> The line
> [https://github.com/apache/thrift/blob/bfba370bf163425823ce7b660f9d123f5fc67c79/lib/py/src/server/TNonblockingServer.py#L177]
>
> {code:java}
> self._wbuf = self.message[sent:]
> {code}
>
> But self.message is never assigned. Maybe should be
> {code:java}
> self._wbuf = self._wbuf[sent:]{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
